texconv: add --ignore-srgb, --wic-uncompressed and revisit --wic-lossless #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 12, 2024
scm-xbox
approved these changes
Nov 12, 2024
walbourn
changed the title
|
In my initial implementation of these switches, I was basing it on the 'general principle' that WIC has ImageQuality is between 0 and 1, and 1 means "lossless if you support it". In practice over time, the tool only sets these on specific codecs so this has resulted in consumer confusion. In addition, I've conflated "no compression" with "lossless" in the case of TIFF. This PR tries to straighten all that out. |
walbourn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--ignore-srgbswitch which passesTGA_FLAGS_IGNORE_SRGBorWIC_FLAGS_IGNORE_SRGBto the loader as appropriate.Adds
--wic-uncompressedswitch which applies to TIFF and HEIF.--wic-losslessshould not be applied to JPEG as it only has a quality setting. This switch now only applies JPEG XR.Add
--wic-qualityhandling for HEIF codec output.Remove
heicas an option for output as the extension can read both, but only supports writinghief.